Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gunicorn worker ssl #1003

Merged
merged 2 commits into from
Jul 25, 2016
Merged

Gunicorn worker ssl #1003

merged 2 commits into from
Jul 25, 2016

Conversation

tumb1er
Copy link
Contributor

@tumb1er tumb1er commented Jul 25, 2016

What do these changes do?

gunicorn provides SSL support for sync workers and for gaiohttp worker for aiohttp.
aiohttp provides GunicornWebWorker, but it lacks SSL support.
This PR allows GunicornWebWorker to init SSL from gunicorn config.

Are there changes in behavior for the user?

No regressions expected

Related issue number

Nope

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage increased (+0.003%) to 97.971% when pulling 0f0b392 on tumb1er:gunicorn_worker_ssl into 072991f on KeepSafe:master.

@asvetlov
Copy link
Member

What is your use case?

From my understanding people starts Reverse Proxy server like Nginx, push Gunicorn behind its and start aiohttp workers under gunicorn.

In this scheme only Nginx serves SSL/TLS connections, all internal communications are insecure and uses raw sockets, isn't it?

@tumb1er
Copy link
Contributor Author

tumb1er commented Jul 25, 2016

My use case is uploading huge files over ssl (without nginx).
With nginx serving connections, it first dumps full request to disk, then reads it and pass to upstream (aiohttp). Yes, nginx support client_body_in_file_only but it is useless in case of multipart requests.

@asvetlov
Copy link
Member

Ok, makes sense

@asvetlov asvetlov merged commit 2606247 into aio-libs:master Jul 25, 2016
@tumb1er tumb1er deleted the gunicorn_worker_ssl branch August 9, 2016 11:26
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants