Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document non-gunicorn based approaches for deployment #1120

Closed
asvetlov opened this issue Aug 25, 2016 · 8 comments
Closed

Document non-gunicorn based approaches for deployment #1120

asvetlov opened this issue Aug 25, 2016 · 8 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers outdated

Comments

@asvetlov
Copy link
Member

  1. Just starting server.
  2. Pushing multiple server processes behind nginx. Nginx config template should be attached.
@asvetlov asvetlov added the good first issue Good for newcomers label Aug 25, 2016
@allan-simon
Copy link

allan-simon commented Sep 24, 2016

what are the advantages/drawbacks of both approach as I think it's good to know why there's an alternative ? I already made for tornado a deployment like you described , nginx with a upstream configured to round-robin accross different processes handled by supervisor so if that's what you looking for, I can create a PR :)

@asvetlov
Copy link
Member Author

You are getting rid of intermediate (gunicorn) but should control/monitor your services by external tool (supervisord or similar).

I very appreciate a contribution into this part of doc.
Looks like I cannot find a time for fixing the issue by myself.

@asvetlov asvetlov added the documentation Improvements or additions to documentation label Sep 24, 2016
@allan-simon
Copy link

I see I think I need to read a bit more about how gunicorn is working, because I always thought it was only for traditionnal sync framework and that it would not play well with asyncio ones (or at least it will hurt 'peformances' by inducing extra buffering etc. )

@asvetlov
Copy link
Member Author

Gunicorn does hurt performance but overhead is relative low.

@ssolari
Copy link

ssolari commented Sep 29, 2016

+1 this would be awsome. Since I was having problems with gunicorn #1223, I tried to run aiohttp web.run_app behind nginx without gunicorn, but couldn't get things to work. Tried just proxy_pass to the 127.0.0.1 port but no go. I'm not sure what i was doing wrong. nginx isn't that easy to understand and the interactions between webservers is really tricky.

@moden-py
Copy link
Contributor

moden-py commented Nov 4, 2016

Search does not work for Nginx+Gunicorn section in deployment.rst.
Steps to reproduce:

  1. open https://aiohttp.readthedocs.io/en/stable/
  2. Type 'Gunicorn' in the Quick search field, press Go
  3. Click on 'Deployment using 'Gunicorn' result
    Actual result: 'This page does not exist yet.'

I'm not sure why, but the 'Gunicorn' result leads to http://aiohttp.readthedocs.io/en/stable/gunicorn.html?highlight=Gunicorn url, although it should lead to some /deployment.html?highlight=Gunicorn

I was unable to find the mistake in deployment.rst.

@asvetlov
Copy link
Member Author

asvetlov commented Nov 4, 2016

Fixed by aiohttp==1.1.1

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers outdated
Projects
None yet
Development

No branches or pull requests

4 participants