Fixed JSON response character set detection. #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 7519 states that JSON *MUST* be encoded in UTF and that the default encoding, in absence of charset in CONTENT_TYPE header is UTF-8. This vastly improves performce when doing many small requests in environments where the server does not specify the character by omitting chardet.
Current coverage is 98.74% (diff: 100%)@@ master #1339 diff @@
==========================================
Files 29 29
Lines 6523 6525 +2
Methods 0 0
Messages 0 0
Branches 1093 1094 +1
==========================================
Hits 6443 6443
- Misses 36 37 +1
- Partials 44 45 +1
|
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This disables running chardet on responses with
CONTENT_TYPE: application/jsonas this is a HUGE performance hit.RFC 7519 states that JSON MUST be encoded in UTF and that
the default encoding, in absence of charset in CONTENT_TYPE header is UTF-8.
This vastly improves performance when doing many small requests in environments
where the server does not specify the character by omitting chardet.
Are there changes in behavior for the user?
This does not change the behaviour unless a non-conforming server sends a HTTP response using an invalid encoding without specifying the encoding correctly in the header.
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.