HttpResponse doesn't parse response body without Content-Length header and Connection: close

[tumb1er]

Steps to reproduce:

1. create server that replies on request with response:

HTTP/1.1 200 OK
Server: nginx/1.4.3
Date: Mon, 24 Feb 2014 13:38:02 GMT
Content-Type: text/plain
Connection: close
Expires: Mon, 24 Feb 2014 13:38:01 GMT
Cache-Control: no-cache

MESSAGE_BODY

2. run curl example:

python examples/curl.py http://video-1-1.rutube.ru/api/tx_bytes

3. GET empty response body in stdout.

That's because in HttpResponse.start method HttpPayloadParser is constructed with only message argument.
So, in HttpPayloadParser.__init__ field self.readall defaults to False and next code in HttpPayloadParser.__call__ is never called:

    if self.readall:
         yield from self.parse_eof_payload(out, buf)

[ghost]

Just ran into this and the above commit: tumb1er@235a6e4 seems to work fine.

[fafhrd91]

i cannot accept this because HttpPayloadParser implementation is used for server as well.
it probably not a bad idea to support responses without content-length for client code because of bad servers, but i think this is against http spec.

[fafhrd91]

added parameter for request() method @76ab7f76ef4e4ab83a35b787baf80fe7fae74454

[tumb1er]

Thanks! What version will it be?

[fafhrd91]

0.6.3, i'll try to release it later today or tomorrow.

[fafhrd91]

new version is released

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.