Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DummyCookieJar helper #1830

Merged
merged 1 commit into from
Apr 22, 2017
Merged

Conversation

alefteris
Copy link
Contributor

What do these changes do?

Adds a DummyCookieJar class in the helpers module. It's a no-op cookie storage that can be used with ClientSession when cookie processing is not needed.

Are there changes in behavior for the user?

No.

Related issue number

There was an issue comment that encouraged this contribution.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new entry to CHANGES.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #1830 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
+ Coverage   97.23%   97.23%   +<.01%     
==========================================
  Files          37       37              
  Lines        7482     7496      +14     
  Branches     1300     1300              
==========================================
+ Hits         7275     7289      +14     
  Misses         87       87              
  Partials      120      120
Impacted Files Coverage Δ
aiohttp/helpers.py 97.66% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8634a...659550b. Read the comment docs.

@fafhrd91
Copy link
Member

great!

lgtm. @kxepal @asvetlov any comments?

@fafhrd91 fafhrd91 merged commit 0ed47a2 into aio-libs:master Apr 22, 2017
@alefteris alefteris deleted the dummy-cookie-jar branch April 22, 2017 15:47
@kxepal
Copy link
Member

kxepal commented Apr 22, 2017

Good one

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants