Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated RequestHandler.finish_connections #2006

Merged
merged 1 commit into from
Jun 24, 2017

Conversation

asvetlov
Copy link
Member

We deprecated it in aiohttp 1.2 and I pretty sure nobody use it now.

@codecov-io
Copy link

codecov-io commented Jun 24, 2017

Codecov Report

Merging #2006 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
- Coverage   97.05%   97.05%   -0.01%     
==========================================
  Files          38       38              
  Lines        7698     7697       -1     
  Branches     1347     1347              
==========================================
- Hits         7471     7470       -1     
  Misses        103      103              
  Partials      124      124
Impacted Files Coverage Δ
aiohttp/web_server.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05fa9e...92a3e85. Read the comment docs.

@asvetlov asvetlov merged commit 7849d6d into master Jun 24, 2017
@asvetlov asvetlov deleted the drop_finish_connections branch June 24, 2017 08:54
fscherf added a commit to pengutronix/aiohttp-json-rpc that referenced this pull request Oct 19, 2017
Further reading:

  aiohttp: Drop deprecated RequestHandler.finish_connections #2006
  aio-libs/aiohttp#2006

Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
webknjaz added a commit to rrader/aio_manager that referenced this pull request Oct 27, 2017
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants