Add prop

[asvetlov]

I guess to add aiohttp.web.StreamResponse.started property.

It should be False if response has not started and True when response.start() has been called.

The reason is: in custom middleware I want to replace response object for, say, rendering pretty looking page for 500 status code.

But if response has been started (it's response for processing streaming video for example) I cannot do that.

Even catching RuntimeError from .start() call cannot solve it if I want to replace the response, not modify it properties.

Objections?

If not I'll prepare full PR with tests etc.

[fafhrd91]

that is valid reason and small change. i think PR is too heavy for that kind of things, just make change.

[kxepal]

Sounds reasonable for me. +1

[ludovic-gasc]

+1

[asvetlov]

I assume +1's as lgtm. Thanks.

P.S. Pull Requests is the best way even for proposals not ready for merging (if it's pointed directly). You can see proposed changes as diff at least.

[fafhrd91]

everything should be in moderation

[fafhrd91]

lgtm

[fafhrd91]

btw there is better api for start() method. start() method can return different object with write_xxx method.
it is late now, but just as notice.

[asvetlov]

@fafhrd91 I don't follow.
start() should make new ResponseImpl for every call?
That's a mess.

[fafhrd91]

main problem right now, that we have two very different state encoded in one class.
state1. response object before send headers
state2. response object after send headers

you can not use response as state2 response if it is in state1 and same for opposite. so obvious solution is just split those two states into different objects. but thats probably not best solution for python and in any case we already have stable api.

[asvetlov]

Got it.

On Mon, Dec 29, 2014 at 10:19 PM, Nikolay Kim notifications@github.com
wrote:

main problem right now, that we have two very different state encoded in
one class.
state1. response object before send headers
state2. response object after send headers

you can not use response as state2 response if it is in state1 and same
for opposite. so obvious solution is just split those two states into
different objects. but thats probably not best solution for python and in
any case we already have stable api.

—
Reply to this email directly or view it on GitHub
#213 (comment).

Thanks,
Andrew Svetlov

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.