Make HTTPException truthy #3098
Conversation
| raise Exception('CustomException') | ||
| except Exception as exc: | ||
| raise web.HTTPException() from exc | ||
| tb = ''.join(format_exception(ei.type, ei.value, ei.tb)) |
There was a problem hiding this comment.
is ei available outside of with block?
There was a problem hiding this comment.
Yes it is.
We use it widely in the test suite:
with pytest.raises(aiohttp.ClientResponseError) as info:
await response.start(connection)
assert info.value.request_info is request_info
Codecov Report
@@ Coverage Diff @@
## master #3098 +/- ##
==========================================
+ Coverage 98.05% 98.05% +<.01%
==========================================
Files 43 43
Lines 7828 7830 +2
Branches 1353 1353
==========================================
+ Hits 7676 7678 +2
Misses 56 56
Partials 96 96
Continue to review full report at Codecov.
|
| raise Exception('CustomException') | ||
| except Exception as exc: | ||
| raise web.HTTPException() from exc | ||
| tb = ''.join(format_exception(ei.type, ei.value, ei.tb)) |
There was a problem hiding this comment.
Yes it is.
We use it widely in the test suite:
with pytest.raises(aiohttp.ClientResponseError) as info:
await response.start(connection)
assert info.value.request_info is request_info
|
@jcjf Thank you |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
psf-chronographer
bot
added
the
bot:chronographer:provided
What do these changes do?
Fixes #3096
Are there changes in behavior for the user?
More informative tracebacks when using
raise fromsyntax.Related issue number
#3096
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.