Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StaticRoute is broken in 0.16.0 #377

Closed
magv opened this issue May 27, 2015 · 2 comments
Closed

StaticRoute is broken in 0.16.0 #377

magv opened this issue May 27, 2015 · 2 comments
Labels
outdated

Comments

@magv
Copy link
Contributor

magv commented May 27, 2015

Hi. In commit d6f4764 you removed limit variable from the StaticRoute class, but that variable is still used over here. Because of this, StaticRoute does not work in 0.16.0 release; it throws this error:

...
    chunk = f.read(self.limit)
AttributeError: 'StaticRoute' object has no attribute 'limit'
asvetlov added a commit that referenced this issue May 27, 2015
@asvetlov
Fix regression in static file handling #377, make 0.16.1 release
badd4ce
@asvetlov
Copy link
Member

Fixed in release 0.16.1

Thanks for report!

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @magv