multiple file upload with same key #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least add a test please. |
|
sure will add do you want me to modiy test_client_request.py or should i add different test file |
|
@pankajnits I suggest adding new test to |
|
thanks added test case for this |
| data = yield from request.post() | ||
| files = data.getall('file') | ||
| for _file in files: | ||
| self.assertEqual(_file.file.closed, False) |
There was a problem hiding this comment.
I'd like check for file content for example.
Say, on first cycle iteration it should be b'binary data 1' and for second pass b'binary data 2'
|
thanks will incorporate this change |
asvetlov
added a commit
that referenced
this pull request
Jul 7, 2015
multiple file upload with same key
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if multiple files are uploaded with same key , only last file descriptor is open and rest is closed