add option to pass Origin header in ws_connect

[rutsky]

This PR allows passing of Origin header to ws_connect().

I believe WebSockets specification requires passing of Origin header (https://tools.ietf.org/html/rfc6455#section-4.2.2).

Some servers requires proper Origin headers (according to specification), so without this patch it's not possible to connect to such servers using ws_connect().

[asvetlov]

Should we support origin parameter for regular request as well?

[rutsky]

Should we support origin parameter for regular request as well?

I think no, in regular request() Origin header can be added manually using headers keyword argument.

I don't know any use cases of Origin header, but in CORS and Web Sockets.
CORS is not needed when building requests manually (client can present himself as same-origin client).

Origin has special meaning in WebSocket protocol (and currently ws_connect doesn't have any way to change headers) so I think it deserves separate keyword argument.

Maybe we should also add headers parameter to ws_connect()?

[rutsky]

According to RFC WS server may require authorization, so adding other headers (Authorization:) would be useful.

[asvetlov]

I've merged the PR.
headers parameter worth to be added also in separate PR.
Not sure about authorization: it looks like edge case and may be solved by headers.

[rutsky]

Not sure about authorization: it looks like edge case and may be solved by headers.

I used Authorization as an example of additional headers that someone may require in ws_connect(), I don't think it should be separate argument --- it definitely should go in headers.

[rutsky]

I have opened bug report for adding headers: #608. I think it deserve "easy" tag.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.