Add aiohttp.web command-line interface to serve apps #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,43 @@ | |||
| from .web import run_app | |||
There was a problem hiding this comment.
Please move the file content to the end of web.py.
There was a problem hiding this comment.
Okay...I wasn't sure about the layout.
I was trying to emulate some resemblance to a package level __main__.py.
Speaking of which could web be turned into a proper sub-package, or would that break backwards compatibility?
There was a problem hiding this comment.
aiohttp will keep flat structure without sub-packages.
|
The tests are needed: I'm fine with mocking |
|
Looks good in general. |
|
@asvetlov Ping |
asvetlov
added a commit
that referenced
this pull request
Jan 19, 2016
Add aiohttp.web command-line interface to serve apps
|
Perfect! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the stuff discussed in issue #733 is implemented, with the exception of an awaitable entry point function. It doesn't make much sense to have an awaitable function since that function is the one creating the event loop.