Don't send body in response to HEAD request #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -851,11 +851,15 @@ def text(self, text): | |||
|
|
|||
| self.body = text.encode(self.charset) | |||
|
|
|||
| def should_send_body(self): | |||
| return (self._req.method.lower() != 'head' and | |||
There was a problem hiding this comment.
No need to convert to lowercase, please use hdrs.METH_HEAD instead
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What these changes does?
Skips sending Response body when request method is HEAD or status code is 204 or 304. Satisfies requirements of RFC7230 an RFC7231 that server MUST NOT send message body in such responses.
How to test your changes?
Test case is included:
test_head_returns_empty_body (tests/test_web_functional.py)
Related issue number
Problems with HEAD responses #820
Checklist