Respect CONNECT method to implement a proxy server #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test |
To be able to implement an HTTP tunneling proxy the payload received on the app logic should be wired to the actual stream and not the `EMPTY_PAYLOAD` one. Of course it would still need to modify the parser in the same way the WebSocket implementation works. Also added some hardening for the `Content-Length` header being `"0"` or some other weird value.
drslump
force-pushed
the
allow-connect-method
branch
from
a2e916f
to
8edc0ea
Compare
|
tests added |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to implement an HTTP tunneling proxy the payload received on the app logic should be wired to the actual stream and not the
EMPTY_PAYLOADone. Of course it would still need to modify the parser in the same way the WebSocket implementation works.Also added some hardening for the
Content-Lengthheader being"0"or some other weird value.