Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop initial query parameters on redirects #853

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Drop initial query parameters on redirects #853

merged 1 commit into from
Apr 26, 2016

Conversation

mickael9
Copy link
Contributor

@mickael9 mickael9 commented Apr 25, 2016 •
edited
Loading

What these changes does?

This drops query parameters specified in the params keyword argument when following a redirect so that the redirected URL is not mistakenly modified.

How to test your changes?

Test case is included:
test_drop_params_on_redirect (tests/test_client_functional.py)

Checklist

  • Code is written and well
  • Tests for the changes are provided
  • Documentation reflects the changes

@asvetlov asvetlov merged commit 63cf125 into aio-libs:0.21 Apr 26, 2016
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickael9 @asvetlov