Skip the preamble in MultipartReader. #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the MultipartReader to ignore the preamble of a multipart message. To quote the RFC: > There appears to be room for additional information prior to the first > boundary delimiter line and following the final boundary delimiter line. > These areas should generally be left blank, and implementations must > ignore anything that appears before the first boundary delimiter line or > after the last one. To do this, the MultipartReader now acts slightly differently at the beginning of the file. Instead of looking for a boundary and excepting if it doesn't find one, it will skip over the initial data looking for the first boundary and start reading from there. If it doesn't find any boundary, it will except similar to how it did before. Fixes aio-libs#880
|
@kxepal could you review? |
|
+1 |
|
Sorry for delay /: |
|
I wonder who does multipart generation with preamble? |
|
thanks! |
|
For the record: the server that I found a preamble in was whatever taleo enterprise edition (http://www.oracle.com/us/products/applications/taleo/enterprise/overview/) uses. It wasn't a large preamble: just some extra CR-LF pairs. Seems like it's valid to have whatever you want in there though. |
|
@obmarg good to know, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What these changes does?
This updates the MultipartReader to ignore the preamble of a multipart
message. To quote the RFC:
To do this, the MultipartReader now acts slightly differently at the
beginning of the file. Instead of looking for a boundary and excepting
if it doesn't find one, it will skip over the initial data looking for
the first boundary and start reading from there.
If it doesn't find any boundary, it will except similar to how it did
before.
How to test your changes?
Parse some multipart responses.
Related issue number
Fixes #880
Checklist