Update web.py #892
Merged
Update web.py #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added backlog option to support more than 128 (default value in "create_server" function) concurrent connections.
| @@ -306,7 +306,8 @@ def run_app(app, *, host='0.0.0.0', port=None, | |||
|
|
|||
| handler = app.make_handler() | |||
| srv = loop.run_until_complete(loop.create_server(handler, host, port, | |||
| ssl=ssl_context)) | |||
| ssl=ssl_context, | |||
There was a problem hiding this comment.
Please remove a trailing whitespace
|
A test and documentation update are required |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What these changes does?
Increases the default concurrent connections accepted by aiohttp.web.run_app() function.
Asyncio, by default, configures this value to 128, but allow to increase it. The run_app() function doesn't allow it. This patch only add the parameter backlog to function definition and pass to the create_server asyncio function.
How to test your changes?
Using ab (Apache Benchmark) to test if concurrent connections was really increased.
Related issue number
I don't know if there's a issue assigned.
Checklist
Added backlog option to support more than 128 (default value in "create_server" function) concurrent connections.