Added a refactoring to separate sending file logic from StaticRoute dispatcher #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ispatcher. This should allow more flexibility in sending the files from request handlers manually.
|
Please resolve merge conflicts |
added 2 commits
June 3, 2016 01:25
| @asyncio.coroutine | ||
| def _sendfile_system(self, req, resp, fobj, count): | ||
| """ | ||
| Write `count` bytes of `fobj` to `resp` starting from `offset` using |
This was referenced Jul 12, 2016
|
There's a problem during Python3.4 test runs with this one. |
|
I know. You've missed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What these changes does?
It separates file sending logic from StaticRoute dispatcher.
How to test your changes?
Functionally, there's no change from the user's perspective, but I've modified the unit tests to handle the change properly.
Related issue number
It should address the following question:
#839
Checklist