content disposition with semicolon in filename

[tumb1er]

aiohttp multipart parser raises BadContentDispositionHeader if filename contains semicolon.
Expected filename being parsed correctly because it's quoted string.

Actually:

>>> from aiohttp.multipart import parse_content_disposition
>>> print(parse_content_disposition('form-data; name="data"; filename="file ; name.mp4"'))
aiohttp/multipart.py:123: BadContentDispositionHeader: form-data; name="data"; filename="file ; name.mp4"
  warnings.warn(BadContentDispositionHeader(header))
(None, {})

aiohttp==0.21.6
python3.4

[tumb1er]

cgi.parse_header parses it correctly, with russian characters support.

[lukasz-madon]

aiohttp doesn't implement specification properly. See my comment for more info #916

[kxepal]

Yes, that's a known bug.

[fafhrd91]

@kxepal can we do something quickly with this issue?

[kxepal]

@fafhrd91 Will take a second look on these days.

[fafhrd91]

thanks!

[fafhrd91]

@kxepal could you handle this before 2.0 (1 week)

[kxepal]

Yes, I have a prototype of fix, need to polish, check and throw in.

[fafhrd91]

@kxepal I need you to push some fix

[fafhrd91]

@kxepal could you fix this

[fafhrd91]

this is partial fix, to properly fix this issue we need new parser

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.