Add IE support for cookie deletion. #966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE<=11 ( !!! ) doesn't support the MaxAge property for cookies so del_cookie() also needs to set the Expires cookie header to support IE. Uses the UTC epoch for a standard expire time.
|
Obviously need to update the cookie tests along with this pull request, I'll add those as well. |
|
Looks good. Please update tests. |
3 tasks
|
Fixed by #994 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds support for IE cookie expiration.
Are there changes in behavior for the user?
Not unless they are deleting cookies, otherwise they will actually delete on IE!
Related issue number
None.
Checklist
IE<=11 ( !!! ) doesn't support the MaxAge property for cookies so del_cookie() also needs to set the Expires cookie header to support IE. Uses the UTC epoch for a standard expire time.