Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for latest version of eslint-plugin-react-hooks #2084

Closed
kaiyoma opened this issue Sep 2, 2019 · 10 comments
Closed

Add support for latest version of eslint-plugin-react-hooks #2084

kaiyoma opened this issue Sep 2, 2019 · 10 comments

Comments

@kaiyoma
Copy link

kaiyoma commented Sep 2, 2019

If you install the latest version of all eslint-related libraries, yarn install spits out this warning:

eslint-config-airbnb@18.0.1" has incorrect peer dependency "eslint-plugin-react-hooks@^1.7.0".

eslint-plugin-react-hooks is now up to version 2.0.1.

@ljharb
Copy link
Collaborator

ljharb commented Sep 2, 2019

Indeed, at the moment we only support v1.

What are the breaking changes in v2?

@kaiyoma
Copy link
Author

kaiyoma commented Sep 2, 2019

I'm actually not sure. I only noticed the yarn install warning and figured I should open an issue.

@ljharb
Copy link
Collaborator

ljharb commented Sep 2, 2019

Someone filed #2083 but also didn’t answer the question.

@tomprats
Copy link
Contributor

tomprats commented Sep 3, 2019

Looks like the breaking change is forbidding top level use*() calls:

@DavidHenri008
Copy link

Is there some change concerning this warning?

@AndreiBehel
Copy link

Any updates on this issue?

@balovbohdan
Copy link

Any progress, guys?

@oleblaesing
Copy link

I'm also interested in solving this issue. Are there some updates on those open PRs?

@LiveFreeAndRoam
Copy link

I am also seeing this issue.

What are the plans for airbnb's support for latest eslint-plugin-react-hooks? If it is no longer keeping pace then I will begin migrating my team away from it. In which case, I'd appreciate alternative recommendations.

@ljharb
Copy link
Collaborator

ljharb commented Feb 25, 2020

This is done in #2090

@ljharb ljharb closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants