From d8cb404da74c302506f91e5928f30cc75109e74d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=8D=8E?= Date: Thu, 11 Nov 2021 23:36:01 +0800 Subject: [PATCH] [eslint config] [base] remove unneeded eslint version check --- packages/eslint-config-airbnb-base/package.json | 3 +-- packages/eslint-config-airbnb-base/rules/style.js | 5 +---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/eslint-config-airbnb-base/package.json b/packages/eslint-config-airbnb-base/package.json index 196f78c2e1..ba2af920da 100644 --- a/packages/eslint-config-airbnb-base/package.json +++ b/packages/eslint-config-airbnb-base/package.json @@ -89,7 +89,6 @@ "dependencies": { "confusing-browser-globals": "^1.0.10", "object.assign": "^4.1.2", - "object.entries": "^1.1.5", - "semver": "^6.3.0" + "object.entries": "^1.1.5" } } diff --git a/packages/eslint-config-airbnb-base/rules/style.js b/packages/eslint-config-airbnb-base/rules/style.js index 2973b258ac..4fad26be00 100644 --- a/packages/eslint-config-airbnb-base/rules/style.js +++ b/packages/eslint-config-airbnb-base/rules/style.js @@ -1,6 +1,3 @@ -const semver = require('semver'); -const eslintPkg = require('eslint/package.json'); - module.exports = { rules: { // enforce line breaks after opening and before closing array brackets @@ -105,7 +102,7 @@ module.exports = { // require line breaks inside function parentheses if there are line breaks between parameters // https://eslint.org/docs/rules/function-paren-newline - 'function-paren-newline': ['error', semver.satisfies(eslintPkg.version, '>= 6') ? 'multiline-arguments' : 'consistent'], + 'function-paren-newline': ['error', 'multiline-arguments'], // disallow specified identifiers // https://eslint.org/docs/rules/id-denylist