new: Move InlineManifestPlugin into the project.
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2020 17:04
milesj
changed the title
InlineManifestPlugin into the project.InlineManifestPlugin into the project.
|
to: @alecklandgraf @hayes |
alecklandgraf
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, I updated html-webpack-plugin to v4. However, this broke the inline-manifest-plugin as it was hard-coded to v3.
Since the latter plugin is very old (2+ years), I opted to copy it into this repo manually. We can now type and update it accordingly when the html plugin changes.
Also added tests to make sure build always works.