Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AIRGMSPolyline.h and AIRGMSPolyline.m references from AirMaps.xcodeproj #1351

Merged
merged 1 commit into from
May 20, 2017

Conversation

itsmepetrov
Copy link
Contributor

@itsmepetrov itsmepetrov commented May 20, 2017

In latest 0.15.1 release I have got an error in iOS build:

testmaps xcworkspace 2017-05-20 11-31-56

This occurs because the AirMaps.xcodeproj contains references to AIRGMSPolyline.h and AIRGMSPolyline.m that were added by #1194

testmaps xcodeproj 2017-05-20 11-17-46

I believe that AirMaps.xcodeproj should not contain any references to files from AirGoogleMaps folder.

After removing this files everything is ok 👍

PS: This is the last thing that does not allow us to upgrade our project to react-native 0.44. I hope you will merge this PR and publish patch to npm 😊

@itsmepetrov
Copy link
Contributor Author

@christopherdro please take a look

Copy link

@isnifer isnifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@Maxwell2022
Copy link

Maxwell2022 commented May 22, 2017

Why is there no CI task to catch this kind of errors?

@itsmepetrov
Copy link
Contributor Author

@Maxwell2022 good question, I think at first need to create a task for CI that initiate new RN project with maps and try to build it.

@christopherdro what do you think?

jiaminglu added a commit to jiaminglu/react-native-maps that referenced this pull request May 24, 2017
* commit '8893578ca6197d0c0a3cacf5aea9c78bfb0a4b99':
  v0.15.2 (react-native-maps#1352)
  Remove AIRGMSPolyline.h and AIRGMSPolyline.m references from AirMaps.xcodeproj (react-native-maps#1351)
  v0.15.1 (react-native-maps#1347)
  fix compile error in rn version >= 0.40 (react-native-maps#1341)
  Add Marker rotation for Google Maps on iOS (react-native-maps#1326)
  Fixing reference to AirMapsExplorer in installation docs (react-native-maps#1328)
  Update README: Use callback in `ref` attribute (react-native-maps#1345)
  [iOS] Added onPress support for Polyline on Google Maps (react-native-maps#1194)
  [rnpm] Fix sourceDir for Android (react-native-maps#1313)
  Update license date (react-native-maps#1316)
  Fix overlay issues in Android introduced in 0.13.1 (react-native-maps#1311)

Conflicts:
	lib/android/googlemap/src/main/java/com/airbnb/android/react/maps/googlemap/AirGoogleMapView.java
	lib/android/gradle.properties
	lib/android/src/main/java/com/airbnb/android/react/maps/AirMapManager.java
	lib/components/MapPolyline.js
sorodrigo pushed a commit to Vizzuality/react-native-maps that referenced this pull request May 26, 2017
* upstream/master: (24 commits)
  v0.15.2 (react-native-maps#1352)
  Remove AIRGMSPolyline.h and AIRGMSPolyline.m references from AirMaps.xcodeproj (react-native-maps#1351)
  v0.15.1 (react-native-maps#1347)
  fix compile error in rn version >= 0.40 (react-native-maps#1341)
  Add Marker rotation for Google Maps on iOS (react-native-maps#1326)
  Fixing reference to AirMapsExplorer in installation docs (react-native-maps#1328)
  Update README: Use callback in `ref` attribute (react-native-maps#1345)
  [iOS] Added onPress support for Polyline on Google Maps (react-native-maps#1194)
  [rnpm] Fix sourceDir for Android (react-native-maps#1313)
  Update license date (react-native-maps#1316)
  Fix overlay issues in Android introduced in 0.13.1 (react-native-maps#1311)
  v0.15.0 (react-native-maps#1305)
  fixing code snippet (react-native-maps#1196)
  small typo fixed (react-native-maps#1211)
  Update installation.md (react-native-maps#1226)
  Fixed path in `android/settings.gradle` (react-native-maps#1230)
  Add babelrc to npmignore (react-native-maps#1246)
  Update installation.md (react-native-maps#1179)
  Update docs to specify how to access event data (react-native-maps#1178)
  Update path in android installation (react-native-maps#1249)
  ...
j8seangel added a commit to Vizzuality/react-native-maps that referenced this pull request May 29, 2017
…native-maps into feature/canvas-android

* 'feature/canvas-android' of github.com:Vizzuality/react-native-maps: (24 commits)
  v0.15.2 (react-native-maps#1352)
  Remove AIRGMSPolyline.h and AIRGMSPolyline.m references from AirMaps.xcodeproj (react-native-maps#1351)
  v0.15.1 (react-native-maps#1347)
  fix compile error in rn version >= 0.40 (react-native-maps#1341)
  Add Marker rotation for Google Maps on iOS (react-native-maps#1326)
  Fixing reference to AirMapsExplorer in installation docs (react-native-maps#1328)
  Update README: Use callback in `ref` attribute (react-native-maps#1345)
  [iOS] Added onPress support for Polyline on Google Maps (react-native-maps#1194)
  [rnpm] Fix sourceDir for Android (react-native-maps#1313)
  Update license date (react-native-maps#1316)
  Fix overlay issues in Android introduced in 0.13.1 (react-native-maps#1311)
  v0.15.0 (react-native-maps#1305)
  fixing code snippet (react-native-maps#1196)
  small typo fixed (react-native-maps#1211)
  Update installation.md (react-native-maps#1226)
  Fixed path in `android/settings.gradle` (react-native-maps#1230)
  Add babelrc to npmignore (react-native-maps#1246)
  Update installation.md (react-native-maps#1179)
  Update docs to specify how to access event data (react-native-maps#1178)
  Update path in android installation (react-native-maps#1249)
  ...
pjaraherrera pushed a commit to pjaraherrera/react-native-maps that referenced this pull request Sep 27, 2017
@arled
Copy link

arled commented Mar 20, 2019

react-native link solved it for me. I got this issue after upgrading to "react-native": "0.59.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants