Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the crashing of the application when Goole Play Services need to be updated #1469

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

nikolay-radkov
Copy link
Contributor

Fix the crashing of the application when a user presses on the map and the Google Play Services need to be updated or at the moment of the process of updating.

E/AndroidRuntime( 5908): java.lang.NullPointerException: Attempt to invoke virtual method 'com.google.android.gms.maps.Projection com.google.android.gms.maps.GoogleMap.getProjection()' on a null object reference
E/AndroidRuntime( 5908): 	at com.airbnb.android.react.maps.AirMapView$13.run(AirMapView.java:643)
E/AndroidRuntime( 5908): 	at android.os.Handler.handleCallback(Handler.java:739)
E/AndroidRuntime( 5908): 	at android.os.Handler.dispatchMessage(Handler.java:95)
E/AndroidRuntime( 5908): 	at android.os.Looper.loop(Looper.java:135)
E/AndroidRuntime( 5908): 	at android.app.ActivityThread.main(ActivityThread.java:5264)
E/AndroidRuntime( 5908): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime( 5908): 	at java.lang.reflect.Method.invoke(Method.java:372)
E/AndroidRuntime( 5908): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:900)
E/AndroidRuntime( 5908): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:695)

…oogle Play Services need to be updated or at the moment of the process of updating
@nikolay-radkov nikolay-radkov changed the title Fix the crashing of the application when Goole Play Services needs to be updated Fix the crashing of the application when Goole Play Services need to be updated Jul 11, 2017
@mattshen
Copy link
Contributor

mattshen commented Jul 17, 2017

This PR is supposed to fix #618

I made a PR to fix the issue as well. #1443

Both PRs should have the same effect.

I think a lot of stuff shouldn't be started if map instance is null. However, I didn't find a perfect point to check nullability of map.

@christopherdro christopherdro merged commit 3235a34 into react-native-maps:master Jul 27, 2017
yosimasu pushed a commit to yosimasu/react-native-maps that referenced this pull request Aug 7, 2017
…oogle Play Services need to be updated or at the moment of the process of updating (react-native-maps#1469)
sorodrigo pushed a commit to Vizzuality/react-native-maps that referenced this pull request Aug 21, 2017
* 'master' of https://github.com/airbnb/react-native-maps:
  v0.16.2
  Revert "Issue1176 improve ios marker performance by X100 (react-native-maps#1187)"
  Fix initial region android (react-native-maps#1563)
  v0.16.1
  Enhance Podfile. (react-native-maps#1252)
  Update marker component (react-native-maps#1428)
  Add legalNotice constant (react-native-maps#1458)
  Issue1176 improve ios marker performance by X100 (react-native-maps#1187)
  Fix initial region native prop (react-native-maps#1546)
  fix `Archive` configuration for iOS builds (react-native-maps#1550)
  v0.16.0
  Document MapView min/max zoom properties (react-native-maps#1538)
  Fix timing function used in AnimatedRegion.spring (react-native-maps#1479)
  Fix crashing the application when a user presses on the map and the Google Play Services need to be updated or at the moment of the process of updating (react-native-maps#1469)
  skip region monitoring if map object is null (react-native-maps#1443)
  Zoom level fixes (react-native-maps#1485)
  Attempt to fix crashes. A variant of react-native-maps#1403 but for another lifecycle method, as proposed by @Nelrohd. (react-native-maps#1464)
  Handle Android RN 0.47 breaking change (react-native-maps#1481)
  add MKTileOverlayRenderer (react-native-maps#1357)
  Add onMapReady callback (react-native-maps#1369)
pjaraherrera pushed a commit to pjaraherrera/react-native-maps that referenced this pull request Sep 27, 2017
…oogle Play Services need to be updated or at the moment of the process of updating (react-native-maps#1469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants