New methods to convert between LatLng and Point #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgindi
force-pushed
the
feature/pt_latlng_conversions
branch
from
ee835a9 to
da2723a
Compare
|
@rborn can we get this moving also? This is very useful and simply exposes basic functionality |
rborn
reviewed
Jan 8, 2018
docs/mapview.md
Outdated
| @@ -71,6 +71,8 @@ To access event data, you will need to use `e.nativeEvent`. For example, `onPres | |||
| | `fitToElements` | `animated: Boolean` | | |||
| | `fitToSuppliedMarkers` | `markerIDs: String[]`, `animated: Boolean` | If you need to use this in `ComponentDidMount`, make sure you put it in a timeout or it will cause performance problems. | |||
| | `fitToCoordinates` | `coordinates: Array<LatLng>, options: { edgePadding: EdgePadding, animated: Boolean }` | If called in `ComponentDidMount` in android, it will cause an exception. It is recommended to call it from the MapView `onLayout` event. | |||
| | `pointForCoordinate` | `coordinate: LatLng` | Converts a map coordinate to a user-space point. Returns a `Promise<Point>`. | |||
There was a problem hiding this comment.
Could you please explain a little more what user-space is? (I suppose we talk view coordinates, right?)
There was a problem hiding this comment.
Yeah it means view-coordinates...
|
@danielgindi thank you 🤗 |
pedrolopes10
pushed a commit
to pedrolopes10/react-native-maps
that referenced
this pull request
Jan 10, 2018
* New methods to convert between LatLng and Point * Clarification for `pointForCoordinate` and `coordinateForPoint`
pedrolopes10
pushed a commit
to pedrolopes10/react-native-maps
that referenced
this pull request
Jan 10, 2018
* New methods to convert between LatLng and Point * Clarification for `pointForCoordinate` and `coordinateForPoint`
pedrolopes10
added a commit
to pedrolopes10/react-native-maps
that referenced
this pull request
Jan 10, 2018
…-maps#1851)" This reverts commit d7226ab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right here, right now, explaining this is a "more is less" situation :-)