Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused NativeMethodsMixin for compat with RN 0.32 #511

Merged

Conversation

spikebrehm
Copy link

Remove the unused NativeMethodsMixin, which is undefined in
react-native 0.32.0, causing yellowbox warnings.

Related: #490

cc: @lelandrichardson

Remove the unused `NativeMethodsMixin`, which is undefined in
`react-native` 0.32.0, causing yellowbox warnings.
@spikebrehm spikebrehm merged commit 90e84ae into react-native-maps:master Aug 30, 2016
@spikebrehm spikebrehm deleted the remove-nativemethodsmixin branch August 30, 2016 21:33
spikebrehm pushed a commit that referenced this pull request Sep 3, 2016
I removed `NativeMethodsMixin` in #511 because the module moved in
0.32.0, which made it throw errors. I assumed we didn't need it because
none of its methods were being called, but I didn't realize that we want
to include it to that consumers of the library can use those methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant