-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all remaining ESLint violations #515
Conversation
To disable certain rules.
Because `react` is listed as a peer dep, so it won't necessarily exist on the filesystem.
I've also smoke-tested all the examples. |
Wow thanks! looks good |
lgtm |
I got |
That's worrisome, because I don't see than locally on In any case, I fixed that and pushed. |
Strange, I'll double check if I have some settings set up somewhere |
Just published 0.8.1 that includes this change. |
It turns out 0.8.1 was faulty, because my working directory had an additional example app containing the |
Fix all remaining ESLint violations. Commits split up mostly by which linting rule addressed.
Next step, after this: set up Travis to automatically run linting on PRs.
cc: @lelandrichardson @christopherdro @jrichardlai