Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] fix getAirMapName to fix ref-based commands #665

Merged
merged 1 commit into from
Oct 10, 2016
Merged

[android] fix getAirMapName to fix ref-based commands #665

merged 1 commit into from
Oct 10, 2016

Conversation

gilbox
Copy link
Contributor

@gilbox gilbox commented Oct 7, 2016 •
edited
Loading

stuff like map.fitToElements() was broken b/c of this.

fitmap

@gilbox
Copy link
Contributor Author

gilbox commented Oct 7, 2016

@spikebrehm @lelandrichardson @felipecsl

@gilbox gilbox force-pushed the gil/fix-android-commands branch from 249e7d6 to 375da11 Compare October 10, 2016 17:45
@spikebrehm
Copy link

👍

Let's release patch versions of 0.9 and 0.10 with this fix.

@spikebrehm spikebrehm merged commit df998ee into master Oct 10, 2016
@spikebrehm spikebrehm deleted the gil/fix-android-commands branch October 10, 2016 18:38
@gilbox
Copy link
Contributor Author

gilbox commented Oct 10, 2016

@spikebrehm I don't think we can patch 0.10.0 without a tag? ʕ ಡ ﹏ ಡ ʔ (my b)

@spikebrehm
Copy link

spikebrehm commented Oct 10, 2016 •
edited
Loading

Doh, always create tags. NPM has a utility for this:

npm version major
npm version minor
npm version patch

Creates git tag, creates git commit with bumped package.json version

@spikebrehm
Copy link

Can you plz retroactively create the 0.10.0 tag at the correct SHA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilbox @spikebrehm