Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zIndex] Add support for setting zIndex on markers #675

Merged
merged 5 commits into from
Oct 13, 2016

Conversation

mlanter
Copy link
Contributor

@mlanter mlanter commented Oct 11, 2016

Add support for setting the z-index on markers via the style.

Example usage:

<MapView.Marker
  style={styles.importantMarker}
  ... 
/>
const styles = StyleSheet.create({
  importantMarker: {
    zIndex: 1,
  },
});

Test plan:

  • Verify on both iOS and Android that with this fix any markers with a zIndex > 0 show up above any other markers.
  • Verify without the change sometimes markers appear below others.

@spikebrehm
Copy link

Awesome, thanks! Can you please add an example to the example app demonstrating this feature? We basically use the example app as manual integration tests.

@carleryd
Copy link

Great job, just tested it and it works great! I have been wanting this feature for a long time, looking forward to seeing it in the next release!

@mlanter
Copy link
Contributor Author

mlanter commented Oct 12, 2016

Here's an example-

screenshot-2016-10-12_13 17 34 140

@spikebrehm
Copy link

@mlanter
Copy link
Contributor Author

mlanter commented Oct 13, 2016

Yep! Here's iOS screenshots for Apple and Google Maps-

simulator screen shot oct 13 2016 1 35 19 am
simulator screen shot oct 13 2016 1 35 26 am

Copy link

@spikebrehm spikebrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much! 🍻

loadingIndicatorColor={"#666666"}
loadingBackgroundColor={"#eeeeee"}
loadingIndicatorColor="#666666"
loadingBackgroundColor="#eeeeee"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spikebrehm spikebrehm merged commit f45e755 into react-native-maps:master Oct 13, 2016
@mlanter mlanter deleted the zindex_pr branch October 13, 2016 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants