Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to RN 0.35 #680

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Upgraded to RN 0.35 #680

merged 1 commit into from
Oct 11, 2016

Conversation

eugenehp
Copy link
Contributor

added fix to RCTImageLoader, missing partialLoadBlock:nil

see https://github.com/airbnb/react-native-maps/blob/master/ios/AirMaps/AIRMapMarker.m#L217

 _reloadImageCancellationBlock = [_bridge.imageLoader loadImageWithURLRequest:[RCTConvert NSURLRequest:_imageSrc]
                                                                            size:self.bounds.size
                                                                           scale:RCTScreenScale()
                                                                         clipped:YES
                                                                      resizeMode:RCTResizeModeCenter
                                                                   progressBlock:nil
                                                                partialLoadBlock:nil
                                                                 completionBlock:^(NSError *error, UIImage *image) {
                                                                     if (error) {
                                                                         // TODO(lmr): do something with the error?
                                                                         NSLog(@"%@", error);
                                                                     }
                                                                     dispatch_async(dispatch_get_main_queue(), ^{
                                                                         self.image = image;
                                                                     });
                                                                 }];

@eugenehp eugenehp changed the title Upgraded to RN 0.35 and Upgraded to RN 0.35 Oct 11, 2016
@ippa
Copy link

ippa commented Oct 11, 2016

this fixes my problem.

@christopherdro christopherdro merged commit 99c3bda into react-native-maps:master Oct 11, 2016
@eugenehp
Copy link
Contributor Author

Thanks @christopherdro

christopherdro pushed a commit to wildlifela/react-native-maps that referenced this pull request Oct 11, 2016
@worldlyjohn
Copy link

thanks @christopherdro! -- any idea when you'll tag another release (0.10.2?) so we can pull from npm?

@christopherdro
Copy link
Collaborator

Yes, I believe @spikebrehm planned on doing one a new release shortly.

@haikyuu
Copy link
Contributor

haikyuu commented Oct 13, 2016

For now, i added "react-native-maps": "airbnb/react-native-maps#master" to my package.json. It worked like a charm 🎉

@kfiroo
Copy link

kfiroo commented Oct 13, 2016

@lelandrichardson @gilbox We should probably publish a new version soon as this repo is not useable with the latest react native version

kfiroo pushed a commit to kfiroo/react-native-maps that referenced this pull request Oct 13, 2016
@valinaga
Copy link

after updating react-native to 0.35 and following @haikyuu change in package.json I get this warning in ExceptionsManager.js
Warning: Native component for "AIRMapUrlTile" does not exist
Any idea? Thanks!

@kfiroo
Copy link

kfiroo commented Oct 14, 2016

@valinaga Try changing it to:
"react-native-maps": "https://github.com/airbnb/react-native-maps.git#f45e75559593f7081692682a113374b5102e25c5"

@kelset
Copy link

kelset commented Oct 14, 2016

I tried to add Google Maps and I had to add partialLoadBlock:nil to the AirGoogleMaps corrispective method too.

@spikebrehm
Copy link

I'll release 0.11.0

@christopherdro
Copy link
Collaborator

Should we mark it as the latest as well?

@spikebrehm
Copy link

In the future, please also update the example app

@@ -215,6 +215,7 @@ - (void)setImageSrc:(NSString *)imageSrc
clipped:YES
resizeMode:RCTResizeModeCenter
progressBlock:nil
partialLoadBlock:nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add this to AIRGoogleMapMarker.m

@spikebrehm
Copy link

Here's my follow-up PR to update the example app and fix a bug in AIRGoogleMapMarker.m: #695

@maurovisintin
Copy link

maurovisintin commented Oct 26, 2016

Hi, with RN 0.35 and maps 0.11, maps seem to work fine (IOS) but I get this console warning

ExceptionsManager.js:82 Warning: Native component for "AIRMapUrlTile" does not exist

AIRMapMarker seems ok.
Any hints?

@valinaga
Copy link

Same here: Warning: Native component for "AIRMapUrlTile" does not exist.

Exilz pushed a commit to archriss/react-native-maps that referenced this pull request Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants