-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to RN 0.35 #680
Upgraded to RN 0.35 #680
Conversation
this fixes my problem. |
Thanks @christopherdro |
thanks @christopherdro! -- any idea when you'll tag another release (0.10.2?) so we can pull from npm? |
Yes, I believe @spikebrehm planned on doing one a new release shortly. |
For now, i added |
@lelandrichardson @gilbox We should probably publish a new version soon as this repo is not useable with the latest react native version |
after updating react-native to 0.35 and following @haikyuu change in package.json I get this warning in ExceptionsManager.js |
@valinaga Try changing it to: |
I tried to add Google Maps and I had to add |
I'll release 0.11.0 |
Should we mark it as the latest as well? |
In the future, please also update the example app |
@@ -215,6 +215,7 @@ - (void)setImageSrc:(NSString *)imageSrc | |||
clipped:YES | |||
resizeMode:RCTResizeModeCenter | |||
progressBlock:nil | |||
partialLoadBlock:nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add this to AIRGoogleMapMarker.m
Here's my follow-up PR to update the example app and fix a bug in |
Hi, with RN 0.35 and maps 0.11, maps seem to work fine (IOS) but I get this console warning
AIRMapMarker seems ok. |
Same here: Warning: Native component for "AIRMapUrlTile" does not exist. |
added fix to RCTImageLoader, missing
partialLoadBlock:nil
see https://github.com/airbnb/react-native-maps/blob/master/ios/AirMaps/AIRMapMarker.m#L217