-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Google Maps Custom Tile Support #770
[iOS] Google Maps Custom Tile Support #770
Conversation
nitaliano
commented
Nov 6, 2016
•
edited
Loading
edited
- Added support for custom tiles with googles maps on iOS
- Updated current example
07f813a
to
397c2e4
Compare
I also added subdomain support in this branch for Android and iOS(google maps and mapkit) can combine that with this one if there are no objections nitaliano/react-native-maps@google-ios-tilelayers...unboundfire:google-ios-tile-subdomains |
397c2e4
to
5ecca7b
Compare
Thanks @unboundfire ( ◠‿◠ ) |
* commit '3d28a7d9fd005d59219668cf61177fe574170b84': (24 commits) examples-setup.md: update android instructions (react-native-maps#743) add example for overlay overpress and docs iOS google maps custom tile support (react-native-maps#770) [Docs] Fix capitalisation of Xcode and CocoaPods (react-native-maps#749) Implements animateToRegion to Google Maps iOS (react-native-maps#779) [RN][iOS][google] Set region only when view has width&height - Fix type issue in AIRMapManager - Setup Gemfile in example/ios dir to avoid problems with different versions of cocoapods - Update examples-setup.md to use bundler - Change MapView so that we only set the native region prop when there is a width and height. GoogleMaps iOS requires the width and height to properly calculate the map zoom level. updates [marker flicker] Fix flicker of map pins on state change (react-native-maps#728) add onPress for polygons and polylines on iOS and Android Use latest Google Play Services (react-native-maps#731) Update installation.md (react-native-maps#742) Add latest patch releases to the changelog (react-native-maps#752) [ios][google] implement fitToSuppliedMarkers and fitToCoordinates (react-native-maps#750) If we've disabled scrolling within the map, then don't capture the touch events (react-native-maps#664) Fix dynamic imageSrc removal, fix flicker in react-native-maps#738 (react-native-maps#737) Fix Anchor point on Google Maps iOS Added ios google maps circle support Added google map type only check Fixed typo in google maps podspec Added ios google maps polygon, polyline, maptype support ...
@unboundfire I am seeing the same problem as gilbox where i'm just getting the beige screen overtop of the map that I used to see. Did you add support for GoogleMaps because you had to, or should it work for Apple maps on iOS too. Are Maptiles formatted in a certain way to work with a specific provider? I used Maptiler and am trying to add the tiles locally for better performance. Haven't seen any examples of that but I assume it is possible.
I switched out my url for the example hosted one and I still get a beige screen, so I'm guessing its because of the provider or something about my installation is broken.
|
@shenst1 map tiles can be formatted in tms which basically inverts the y axis. The current implementation in react-native-maps does not support these types of map tiles. I have gotten these types of tiles to work on my own branches. I had a hackathon recently where I added this support to react-native-maps on one of my branches for gmaps on iOS to always have the y axis inverted. https://github.com/unboundfire/react-native-maps/tree/subdomains Here is the diff master...unboundfire:subdomains Look at Let me know if this helps, would be happy to send a proper PR out for this that works on both Android and iOS(gmaps, apple) |
@unboundfire thanks for the response. I'm not sure if my tiles are formatted in TMS. Right now I'm having problems getting any tiles to work, starting with the demo. I created a new react-native project with only one component based off the example in the air-bnb repo. Completely isolated and with the demo i'm still getting just a beige map. If i delete the maptile, the map shows san francisco just fine. |