Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS Google Map styling #817

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Conversation

alialamine
Copy link
Contributor

@alialamine alialamine commented Nov 22, 2016

Adds support to google map styling for ios.

fix #781

Added the map styling to ios

Fixed the android build that broke

Fixed some styling issues
@gilbox
Copy link
Contributor

gilbox commented Nov 22, 2016

image

@gilbox gilbox merged commit 6a978b3 into react-native-maps:master Nov 22, 2016
@gilbox gilbox mentioned this pull request Nov 22, 2016
@nrathi
Copy link

nrathi commented Nov 23, 2016

Thanks for this change! I think I'm missing something though -- how do I tell iOS to use Google Maps instead of Apple?

@gilbox
Copy link
Contributor

gilbox commented Nov 23, 2016

provider={MapView.PROVIDER_GOOGLE}

@nrathi
Copy link

nrathi commented Nov 23, 2016

Hmm this isn't working for me. (The map maintains its default style.) Is it because it's not apart of the latest release? Here's my code:

    return (
      <View style={BaseStyles.container}>
        <MapView
          provider={MapView.PROVIDER_GOOGLE}
          style={StyleSheet.absoluteFill}
          customMapStyle={mapStyle}
          region={this.state.mapRegion}
          showsUserLocation={true}>
          {fromMarker}
          {toMarker}
          {polyLine}
        </MapView>
        {clearButton}
        <View style={styles.view}>
          {whereTo}
          {timePicker}
        </View>
        {parkHere}
        {resultSet}
      </View>
    );
  }

const mapStyle = [ /** some JSON from https://mapstyle.withgoogle.com */ ];

@alialamine
Copy link
Contributor Author

@nrathi no it's not yet

@gilbox Any chance of pushing a new release to npm? I think a lot of people need this.

@mCzolko
Copy link

mCzolko commented Nov 27, 2016

🐑 🇮🇹
🙏
@gilbox do us the favor of release 😃

@mCzolko
Copy link

mCzolko commented Nov 28, 2016

@spikebrehm could you help gilbox with releasing this to NPM?

@nrathi
Copy link

nrathi commented Nov 28, 2016

https://github.com/airbnb/react-native-maps/pull/722/files

@spikebrehm, this would also be great to have.

@gilbox
Copy link
Contributor

gilbox commented Dec 6, 2016

v0.12.1 is published

Exilz pushed a commit to archriss/react-native-maps that referenced this pull request Dec 9, 2016
@alialamine alialamine deleted the ios-styling branch December 28, 2016 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapStyleOptions
4 participants