fix(scripts/performRelease): add comment, fix typo #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Mar 17, 2021
|
The removal of the |
|
🎉 This PR is included in version |
|
^yeah I agree, it's a bit of a tradeoff but I think this is the way to go for now. we can always reconsider in the future. |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
This is mostly a PR to trigger a non-
alpha-release, because of an implication of the release flow I hadn't fully internalized (and rather than committing something random, I added a comment about this implication to the release script 😄 ):If there are any PRs since the last tag which have an
alpha-releaselabel, the release will be analpha-release(#1107 had this tag and thus the release was an alpha, I've since removed that tag). Here's an example
tag @ whatevercreatedalpha-release+patch-release=> triggersalpha patchminor-release=> triggersalpha minoralpha-releasefrom PR 1patch-release=> triggersnon-alpha minor(minorrequired from PR 2)The alternative I think is to perform a non-alpha release if there are PRs that are merged after the
alpha-release-tagged PR (in the example above, that would mean after PR 2 is merged, aminorrelease would be triggered). This seems like it could lead to unintentional non-alpha-releases if multiple people are merging things, so simply requiring the removal ofalpha-releasetags seems safer to me. Note in the example above, if you wanted PR 2 to trigger aminorrelease, you would just need to remove the alpha label from PR 1 prior to merging.Open to feedback tho!
@kristw @hshoff