Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brush does not resize when width and height props update #1436

Closed
wilson-webdev opened this issue Feb 17, 2022 · 2 comments
Closed

Brush does not resize when width and height props update #1436

wilson-webdev opened this issue Feb 17, 2022 · 2 comments
Labels
🐛 bug 👋 help wanted @visx/brush

Comments

@wilson-webdev
Copy link

This issue was mentioned here, but I can't see an explicit issue, so here goes...

Steps to replicate:

  1. Go to the Brush example
  2. Update the Brush so that it is not the default size
    Screenshot 2022-02-17 at 12 33 16
  3. Resize chart and see the Brush has not resized Screenshot 2022-02-17 at 12 33 28
@williaster
Copy link
Collaborator

thanks for reporting this @wilson-webdev 🙏 I don't have bandwidth to address it at the moment but happy to review a PR 👀

@lucassarcanjo lucassarcanjo mentioned this issue Jul 6, 2022
Merged
@williaster
Copy link
Collaborator

fixed by #1536

@datananda datananda mentioned this issue Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug 👋 help wanted @visx/brush
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@williaster @wilson-webdev