Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visx/demo - Gallery page mobile UI issues #1859

Open
kwconrad opened this issue Jul 15, 2024 · 2 comments
Open

visx/demo - Gallery page mobile UI issues #1859

kwconrad opened this issue Jul 15, 2024 · 2 comments

Comments

@kwconrad
Copy link

Hey folks,

I found that if you were on the Gallery page on mobile that there were a couple of UI bugs (see image below).

  1. 🐛 The maximum allowed width of the gallery tile grid was 95vw, with overflow hidden, causing the appearance of a white block over the Gallery tiles.
  2. 🐛 The border does not show up because the box-sizing model is not set to border-box (I believe it defaults to content-box).
  3. 🐛 The filter label ("Filter") and filters (ie "annotation") text is pushed together on the x-axis.

airbnb io_visx_gallery(iPhone XR)

@hshoff
Copy link
Member

hshoff commented Jul 15, 2024

Thanks @kwconrad, the team is aware of these issues. We aim to address them in a future docs update. Happy to review any PRs for existing docs improvements.

@kwconrad
Copy link
Author

Sounds good, @hshoff, thanks for the reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants