New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] commit yarn.lock file #626

Closed

williaster opened this issue Feb 15, 2020 · 0 comments · Fixed by #695

Collaborator

williaster commented Feb 15, 2020

We've gotten bitten several times when a patch version breaks the build, which wouldn't be as likely if we commit the yarn.lock

We can add a dangerjs to ensure that the lock files is updated when a dep is updated to ensure it's valid.

williaster changed the title ~~[internal] commit yarn.lock file and add dangerjs check~~ [internal] commit yarn.lock file

williaster mentioned this issue

internal: commit yarn.lock file #695

Merged

williaster closed this as completed in #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment