Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip Positioning Issue in Functional Components #675

Closed
ahmetuysal opened this issue May 6, 2020 · 3 comments · Fixed by #685
Closed

Tooltip Positioning Issue in Functional Components #675

ahmetuysal opened this issue May 6, 2020 · 3 comments · Fixed by #685

Comments

@ahmetuysal
Copy link

Hi, I am using vx for a project and spent several hours trying to correctly position a tooltip. In the sandbox provided in the docs its says that withTooltip wraps the component in a <div style="position: relative" />.

I think we should also manually do this for FunctionalComponents when using useTooltip (this is how I solved my positioning issue). If this is the case, can you please add a clear explanation to the docs?

Thank you for your amazing work!

@williaster
Copy link
Collaborator

@ahmetuysal 👋 , thanks for checking out vx. Ah yes, this is nuanced and should probably be added to get people going more quickly. I'd like to add a tooltip-only demo soon for the v1 release, in the meantime we could probably add this to the readme to get most of the way there?

PRs, welcome, otherwise I'll probably add it when adding a tooltip demo 👍

@williaster williaster added this to the v1 milestone May 11, 2020
@ahmetuysal
Copy link
Author

Sure, I will add it and open a pull request :)

@ahmetuysal
Copy link
Author

Ah, you already opened a PR, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants