Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xychart] can't set strokeWidth through verticalCrosshairStyle #990

Closed
Janpot opened this issue Jan 5, 2021 · 1 comment · Fixed by #997
Closed

[xychart] can't set strokeWidth through verticalCrosshairStyle #990

Janpot opened this issue Jan 5, 2021 · 1 comment · Fixed by #997
Labels
🐛 bug @visx/xychart

Comments

@Janpot
Copy link
Contributor

Janpot commented Jan 5, 2021 •
edited
Loading

Setting strokeWidth to something greater than 1 in verticalCrosshairStyle on XYChart doesn't have any effect. Havent't tested it out, but from reviewing the code, I think this svg width of 1 is causing the trouble here.

Can potentially be solved by adding CSS overflow:visible to that svg element.
@williaster
Copy link
Collaborator

thanks for reporting this @Janpot , I can prob get a fix out later today 👍

@williaster williaster mentioned this issue Jan 6, 2021
Merged
@Janpot Janpot mentioned this issue Jul 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug @visx/xychart
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(xychart/Tooltip): enable style overflow in crosshairs airbnb/visx
2 participants
@Janpot @williaster