Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move render subcommand from airshipctl document to airshipctl phase #247

Closed
eak13 opened this issue May 19, 2020 · 3 comments
Closed

Move render subcommand from airshipctl document to airshipctl phase #247

eak13 opened this issue May 19, 2020 · 3 comments
Assignees
@raliev12
Labels
enhancement New feature or request priority/medium Default priority for items
Milestone
betav1

Comments

@eak13
Copy link

eak13 commented May 19, 2020

Problem description (if applicable)
With the current design approach, the render sub-command is being implemented in airshipctl phase. This issue is to ensure that the render sub-command is removed from airshipctl document.

Potential impacts
Ensures that deprecated code is removed from the document command and moved to the phase command.
@eak13 eak13 added enhancement New feature or request triage Needs evaluation by project members labels May 19, 2020
@raliev12
Copy link
Contributor

I'd like to pickup this one.

@jezogwza jezogwza added this to the betav1 milestone May 20, 2020
@jezogwza jezogwza added priority/medium Default priority for items and removed triage Needs evaluation by project members labels May 20, 2020
@dukov
Copy link
Member

dukov commented May 20, 2020

https://review.opendev.org/#/c/698658/

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label May 22, 2020
@airshipbot
Copy link

airshipbot commented May 22, 2020 •
edited
Loading

Related Change #698658

Subject: Implement document rendering sub-command
Link: https://review.opendev.org/698658
Status: MERGED
Owner: Dmitry Ukov (dukov@mirantis.com)

This change will close this issue when merged.

Approvals

Code-Review
+2 Matt McEuen
+1 Ruslan Aliev
+2 Ian Howell
Verified
+2 Zuul
Workflow
+1 Ian Howell

Last Updated: 2020-05-27 16:30:04 CDT

@eak13 eak13 mentioned this issue Jul 2, 2020
Closed
@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raliev12 raliev12

Labels
enhancement New feature or request priority/medium Default priority for items
Projects
None yet
Milestone
betav1
Development

No branches or pull requests
5 participants
@dukov @eak13 @jezogwza @raliev12 @airshipbot