Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move clisterctl api definitions to global api module #269

Closed
dukov opened this issue Jun 8, 2020 · 2 comments
Closed

Move clisterctl api definitions to global api module #269

dukov opened this issue Jun 8, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dukov
Copy link
Member

dukov commented Jun 8, 2020

Problem description (if applicable)
Currently all Go structs for clusterctl client defined under pkg/clusterctl/api/v1alpha1/ directory.
Airshipctl is going to introduce a number of custom resources (e.g Phase, PhasePlan e.t.c). It seems like reasonable place for all such resources is pkg/api/v1alpha1 directory

Proposed change
Move pkg/clusterctl/api/v1alpha1/ to pkg/api/v1alpha1/

Potential impacts
Go code imports will be updated

@dukov dukov added enhancement New feature or request triage Needs evaluation by project members labels Jun 8, 2020
@dukov dukov self-assigned this Jun 8, 2020
@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Jun 8, 2020
@airshipbot
Copy link

airshipbot commented Jun 8, 2020

Related Change #734128

Subject: Move clusterctl api structs to gloabal api module
Link: https://review.opendev.org/734128
Status: MERGED
Owner: Dmitry Ukov (dukov@mirantis.com)

This change will close this issue when merged.

Approvals

Code-Review
+2 Kostyantyn Kalynovskyi
+1 Vladimir Kozhukalov
+2 Ian Howell
Verified
+2 Zuul
Workflow
+1 Ian Howell

Last Updated: 2020-06-08 17:15:04 CDT

@airshipbot
Copy link

The Change that closes this issue was merged.

@airshipbot airshipbot added ready for review Change related to the issue is ready for review and removed ready for review Change related to the issue is ready for review triage Needs evaluation by project members labels Jun 8, 2020
@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants