Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude kubeconfig from airshipctl config use-context update #294

Closed
eak13 opened this issue Jul 15, 2020 · 5 comments
Closed

Exclude kubeconfig from airshipctl config use-context update #294

eak13 opened this issue Jul 15, 2020 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@eak13
Copy link

eak13 commented Jul 15, 2020

Proposed change
When airshipctl config use-context is executed, the specified context should be switched in airshipconfig only. Per issue #264, kubeconfig has moved to the manifest document set and would be updated through kustomize and should not be included in the use-context update. This change should ensure kubeconfig is not part of use-context switching.

@eak13 eak13 added enhancement New feature or request triage Needs evaluation by project members labels Jul 15, 2020
@eak13
Copy link
Author

eak13 commented Jul 15, 2020

This issue was opened based on 7/15 Flightplan call in lieu of #290.
Dependencies #264 & #230

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Jul 16, 2020
@airshipbot
Copy link

airshipbot commented Jul 16, 2020

Related Change #741478

Subject: Exclude kubeconfig from use-context update
Link: https://review.opendev.org/741478
Status: MERGED
Owner: Vladislav Kuzmin (vkuzmin@mirantis.com)

This change will close this issue when merged.

Approvals

Code-Review
+2 Dmitry Ukov
+2 Kostyantyn Kalynovskyi
Verified
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2020-08-20 00:15:04 CDT

@jezogwza jezogwza added this to the betav1 milestone Jul 22, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Jul 22, 2020
@airshipbot
Copy link

airshipbot commented Aug 2, 2020

Related Change #744382

Subject: Adding kubeconfig interface
Link: https://review.opendev.org/744382
Status: ABANDONED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
! None
Verified
+1 Zuul
Workflow
! None

Last Updated: 2020-08-07 11:30:04 CDT

@airshipbot
Copy link

airshipbot commented Aug 7, 2020

Related Change #745262

Subject: Adding kubeconfig flags and provider
Link: https://review.opendev.org/745262
Status: ABANDONED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
-1 Dmitry Ukov
Verified
+1 Zuul
Workflow
! None

Last Updated: 2020-08-13 21:15:03 CDT

@airshipbot
Copy link

The Change that closes this issue was merged.

@airshipbot airshipbot added ready for review Change related to the issue is ready for review and removed ready for review Change related to the issue is ready for review labels Aug 20, 2020
@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants