Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import from airshipctl config #329

Closed
lb4368 opened this issue Aug 26, 2020 · 4 comments
Closed

Remove import from airshipctl config #329

lb4368 opened this issue Aug 26, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request ready for review Change related to the issue is ready for review
Milestone

Comments

@lb4368
Copy link

lb4368 commented Aug 26, 2020

Problem description (if applicable)
As a result of investigation from issue #266, it is determined that the config import command will no longer be needed as a result of the config refactoring effort.

Proposed change
Cleanup and remove import subcommand from airshipctl config.

@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members labels Aug 26, 2020
@lb4368 lb4368 assigned lb4368 and unassigned lb4368 Aug 26, 2020
@lb4368
Copy link
Author

lb4368 commented Aug 26, 2020

There is an in-progress patchset at https://review.opendev.org/740719.

@sirajyasin
Copy link
Contributor

I can follow-up on my open PS and take it forward as per the review comments.

@airshipbot
Copy link

airshipbot commented Sep 1, 2020

Related Change #740719

Subject: Prepare gate to remove airshipctl import
Link: https://review.opendev.org/740719
Status: MERGED
Owner: Sirajudeen (sirajudeen.yasin@gmail.com)

This change will close this issue when merged.

Approvals

Code-Review
+1 Ruslan Aliev
+2 Kostyantyn Kalynovskyi
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-09-15 18:00:04 CDT

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Sep 1, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Sep 2, 2020
@jezogwza jezogwza added this to the betav1 milestone Sep 2, 2020
@airshipbot airshipbot added wip Work in progress ready for review Change related to the issue is ready for review and removed ready for review Change related to the issue is ready for review wip Work in progress labels Sep 10, 2020
@airshipbot
Copy link

The Change that closes this issue was merged.

@airshipbot airshipbot added ready for review Change related to the issue is ready for review and removed ready for review Change related to the issue is ready for review labels Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for review Change related to the issue is ready for review
Projects
None yet
Development

No branches or pull requests

4 participants