-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade capm3, bmo and ironic version to v0.4.2 #554
Comments
A few notes:
|
@jgu17, we have this issue #518 to investigate upgrading the components but wanted to wait until after v2.1 was out the door to understand what impact the upgrades might have in Airship before proceeding. Thinking we might be able to combine these 2 issues. If you're OK with it, I can just copy over the #518 description to this issue seeing you've provided more detail here. LMK if that's ok. |
@ak3216 Sure, makes sense to combine. It doesn't matter to me which one you want to keep. |
Before upgrading we need to understand the following (pulled over from #518).
Sources Cluster API: https://github.com/kubernetes-sigs/cluster-api/releases |
Notes from @Arvinderpal from #518 Upgrade to v0.4 (aka v1alpha4)Upgrading CAPI and Provider Components (e.g. v0.3.16 --> v0.4.0)The Upgrading API object (e.g. v1alpha3 --> v1alpha4)clusterctl does not upgrade Cluster API objects (Clusters, MachineDeployments, Machine etc.); upgrading such objects are the responsibility of the provider’s controllers. Clusterctl Libraryairshipctl consumes clusterctl as a library. As of April, 16th, we are importing v0.3.13.
K Version Upgrades
|
@digambar's comments: "CAPM3 has hard dependency on BMO and ip-address-manager so you end up getting dependency mismatch error if you don't upgrade both the controller. I recommend to upgrade both CAPM3 and ip-address-manager along with BMO." It starts to look like that we may need to have a single patchset to upgrade capm3, bmo, ironic and ipam because of the hard dependency among them. |
please assign it to me |
@SirishaGopigiri done! |
@SirishaGopigiri I already started the work on it: https://review.opendev.org/c/airship/airshipctl/+/793254. Had been on a temporary hold because I needed to have a virtual dev env to continue testing/development and also it is planned only for 2.2 release. I just rebased the PS yesterday and was going to resume the work now that I got a lab env. Do you want to work on it together since it is actually quite a big piece or want to take over entirely? |
@jgu17 , please include either the Relates-To or Closes tags in your PS(s) as they're related to issues. This tag helps us track and correlate the issues-to-PSs. And, if the Closes tag is used, a bot will automatically close the respective GitHub issue. https://github.com/airshipit/airshipctl/blob/master/CONTRIBUTING.md#submitting-changes. Thanks. |
We need this uplift as a stepping stone before #518 so we're not skipping versions from 0.3.x to 0.5.x. Additionally, upgrading should address #558 & #559, though #558 has a dependency on metal3-io/ironic-image#266 |
upgrade bmo and ironic is working to the extent that capm3 is throwing an error about node01 not found when updating the baremetal. I suspect it could a version mismtach issue. so I am going to update capm3 version to the same subminor version as the bmo and ironic. @SirishaGopigiri I want to double check with you if you already have an y work in progress in capm3 version upgrade? |
@jgu17 Can you paste the exact error in capm3? Make sure that capm3 and bmo are installed in the same namespace - for exampl: |
@Arvinderpal here the error message from the capm3 pod: |
What is All the resources should be in the same namespace. For example, M3M and BMH should be in the same namespace (e.g. |
tart-infra must have been a copy and paste error when I pasted the logs here. The namespaces for the capm3 and bmo/ironic are actually different even before this upgrade effort. here is the kubectl output for the capm3 pods and bom/ironic pods (same namespace names before and after the bmo version upgrade): This worked before the upgrade and also works for the first controller node baremetal provisioning after the version upgrade. But after the version upgrade, it failed when trying to repurpose the ephemeral node. |
Ok. The second part of my question was where do the M3M and BMH resources reside? The error you pasted says that the capm3 could not find the BMH in |
Problem description (if applicable)
metal3 cluster api provider (capm3, baremetal oprator) has released v0.4 (latest v0.4.2 released on June 1st, 2021). There are a list of new features available: https://github.com/metal3-io/cluster-api-provider-metal3/releases.
v0.4.0
V1alpha4 API Support for Metadata and Network data in Cloud-init
Metadata and network data templating for Machine deployments and KCPs
Raw image streaming
BMO is now deployed as part of CAPM3
Support for IP Address Management as part of metadata templating
Pivoting support
v0.4.1
Adopt BMO kubebuilder changes (#137)
Add Support for Ironic Basic auth and TLS in deployment templates (#134)
v0.4.2
Add live-iso support to CAPI Metal3 provider (#189)
Add unit test and documentation for TemplateReference (#190)
Add nodeReuse feature (#169)
Uplift BMO in go.mod (#193)
Add golint and generate test in travis (#192)
Adds a new controller to synchronize labels between BMHs and K Nodes (#152)
Install kustomize also in Mac OS. (#188)
Update Essential tooling for CAPM3 (#181)
Update go.mod (#153)
Add manifest linting script (#149)
Add nodeDrainTimeout for example cluster template (#142)
Proposed change
Upgrade to latest release of capm3 and bmo
Potential impacts
V0.4.1 added TLS and Basic auth vars for capm3 v0.4.1 release that AS2 could potentially take advantage?
The text was updated successfully, but these errors were encountered: