Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade KPT from v0.37.1 to v1.0.0-beta.x #598

Closed
eak13 opened this issue Jul 9, 2021 · 8 comments
Closed

Upgrade KPT from v0.37.1 to v1.0.0-beta.x #598

eak13 opened this issue Jul 9, 2021 · 8 comments
Assignees
@dinesh14nish
Labels
enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release ready for review Change related to the issue is ready for review size m
Milestone
v2.1

Comments

@eak13
Copy link

eak13 commented Jul 9, 2021 •
edited
Loading

Problem description
In an effort to keep Airship current with the latest updates of its supporting components, upgrade KPT (Kubernetes Package Toolkit) from v0.37.1 to v1.0.0-beta. In making this upgrade, we will need to ensure that KPT continues to perform component package/component upgrades as well.

Documentation for version >= v1.0 - https://kpt.dev/ < May be blocked if trying to access inside a firewall
Documentation for version <= v0.39 - https://googlecontainertools.github.io/kpt/
Release information: https://github.com/GoogleContainerTools/kpt/releases

Proposed change

  • Identify any major/breaking changes that will come with the upgrade & socialize on the Community Design Call prior to performing the upgrade.
  • After Design Call review, upgrade KPT to v1.0.0-beta.x (beta.1 was released June 22, 2021)
  • Make any changes necessary to ensure KPT continues to perform package updates with the move to v1.0.0-beta
  • Validate component upgrades performed by KPT are successful
@eak13 eak13 added enhancement New feature or request triage Needs evaluation by project members labels Jul 9, 2021
@eak13 eak13 added this to the v2.1 milestone Jul 9, 2021
@eak13 eak13 added the priority/critical Items critical to be implemented, usually by the next release label Jul 9, 2021
@matthew-fuller
Copy link
Contributor

Please assign this to me.

@eak13
Copy link
Author

eak13 commented Jul 13, 2021

@matthew-fuller done

@jezogwza jezogwza removed the triage Needs evaluation by project members label Jul 14, 2021
@matthew-fuller
Copy link
Contributor

https://review.opendev.org/c/airship/airshipctl/+/800827

@matthew-fuller
Copy link
Contributor

I've been able to successfully update individual packages after converting Kptfiles to the new format, such as manifests/function/flux/base/upstream/policies, but the new v1.0-beta doesn't seem to support the notion of a local top-level package that lists dependent upstream packages, so there's no easy way to update everything at once. It requires running something like kpt pkg update upstream/policies; kpt pkg update upstream/rbac, etc.

@seaneagan found an issue that seems to be related to this problem. Not sure if there's another way around this issue yet, still investigating...

@eak13 eak13 added the size m label Jul 27, 2021
@matthew-fuller matthew-fuller added the ready for review Change related to the issue is ready for review label Aug 3, 2021
@dinesh14nish
Copy link

Matthew, Are you working on this? if not can you please assign it me so i can take it forward from here.

@dinesh14nish
Copy link

there is an issue with KPT v1.0.0-beta.x itself kptdev/kpt#1544 which is still not resolved. It is blocked due to this reason.

@eak13 eak13 assigned dinesh14nish and unassigned matthew-fuller Nov 10, 2021
@dinesh14nish
Copy link

Change made to https://review.opendev.org/c/airship/airshipctl/+/800827

@dinesh14nish
Copy link

PS https://review.opendev.org/c/airship/airshipctl/+/800827 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dinesh14nish dinesh14nish

Labels
enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release ready for review Change related to the issue is ready for review size m
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@eak13 @jezogwza @dinesh14nish @matthew-fuller