Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Understand CoreDNS upgrades for an existing cluster #608

Closed
eak13 opened this issue Jul 12, 2021 · 6 comments
Closed

Spike: Understand CoreDNS upgrades for an existing cluster #608

eak13 opened this issue Jul 12, 2021 · 6 comments
Assignees
Labels
Day2 Relates to day 2 operations (brownfield upgrades, etc.) enhancement New feature or request priority/medium Default priority for items
Milestone

Comments

@eak13
Copy link

eak13 commented Jul 12, 2021

Problem Statement
We need to get a better understanding of the implications of upgrading the CoreDNS component in a brownfield scenario.

https://coredns.io/
https://coredns.io/2021/05/28/coredns-1.8.4-release/ < latest release notes

Proposed Change

  • Can you upgrade CoreDNS independent of a kubernetes upgrade via CAPI?
  • How disruptive is an upgrade? (i.e. no-op vs. reboot cluster?)
  • Can you deploy an explicit version vs. the k8s default?
  • Any other pertinent information for a CoreDNS upgrade
@eak13 eak13 added enhancement New feature or request triage Needs evaluation by project members labels Jul 12, 2021
@eak13 eak13 changed the title Spike: Understand Core DNS upgrades for an existing cl Spike: Understand Core DNS upgrades for an existing cluster Jul 12, 2021
@eak13 eak13 changed the title Spike: Understand Core DNS upgrades for an existing cluster Spike: Understand CoreDNS upgrades for an existing cluster Jul 12, 2021
@eak13 eak13 added this to the v2.2 milestone Jul 13, 2021
@eak13 eak13 added the Day2 Relates to day 2 operations (brownfield upgrades, etc.) label Jul 13, 2021
@jezogwza jezogwza added priority/medium Default priority for items and removed triage Needs evaluation by project members labels Jul 14, 2021
@SaurabhArora86
Copy link

I can work on it, please assign it to me.

@SaurabhArora86
Copy link

@ak3216 What are we thinking for the outcome of this Issue. Hackmd link or some kind of document

@eak13
Copy link
Author

eak13 commented Aug 5, 2021

@SaurabhArora86 that would be great, or you can just update in the comments here. Would also ask that you add a topic to the design call agenda so we can review with the broader team.

@SaurabhArora86
Copy link

coreDNS.docx
This is a WIP copy

@SaurabhArora86
Copy link

SaurabhArora86 commented Sep 1, 2021

As per what was discussed in Design call, it is best to upgrade CoreDNS as a part of Kubernetes upgrade in CAPI rather than upgrading CoreDNS individually.

Majorly because:

  1. CAPI has feature of handling Corefile upgrade along with CoreDNS rather than manually updating Corefile (in case of Only CoreDNS upgrade).

  2. Updating only CoreDNS image in KCP spec, causes entire CAPI to reconcile and spin up a new machine rather than just updating CoreDNS deployment.

  3. KCP needs to be annotated to exclude CoreDNS from its scope.

All this has been described as a part of Hackmd link Spike: Understand CoreDNS upgrades for an existing cluster - HackMD.0

@lb4368
Copy link

lb4368 commented Sep 7, 2021

@lb4368 lb4368 closed this as completed Sep 8, 2021
@eak13 eak13 modified the milestones: v2.2, v2.1 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Day2 Relates to day 2 operations (brownfield upgrades, etc.) enhancement New feature or request priority/medium Default priority for items
Projects
None yet
Development

No branches or pull requests

4 participants