Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envtest control plane is insufficient #3

Open
seaneagan opened this issue Mar 26, 2021 · 1 comment
Open

envtest control plane is insufficient #3

seaneagan opened this issue Mar 26, 2021 · 1 comment
Labels
enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release priority/medium Default priority for items
Milestone
Future

Comments

@seaneagan
Copy link
Contributor

Problem description (if applicable)
The envtest control plane only has apiserver and etcd, and so lacks the ability to actually reconcile workloads, such as:
1) The DaemonSet produced by VINO
2) Others?

This code currently waits for the DaemonSet to be reconciled, but in the tests this never happens, so this is blocking unit testing from progressing.

Proposed change
See airshipit/sip#14.
We should follow a consistent approach across sip/vino.
@seaneagan seaneagan added enhancement New feature or request triage labels Mar 26, 2021
@lb4368 lb4368 added this to the v2.1 milestone Mar 26, 2021
@jezogwza jezogwza added priority/medium Default priority for items and removed triage labels Apr 21, 2021
@lb4368 lb4368 added the priority/critical Items critical to be implemented, usually by the next release label Apr 26, 2021
@eak13 eak13 modified the milestones: v2.1, Future May 12, 2021
@manojkva
Copy link

manojkva commented Jun 3, 2021

Please assign this to me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release priority/medium Default priority for items
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@seaneagan @manojkva @lb4368 @eak13 @jezogwza