Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performTestRSASign function #189

Closed
ghost opened this issue Nov 7, 2019 · 0 comments · Fixed by #198
Closed

Fix performTestRSASign function #189

ghost opened this issue Nov 7, 2019 · 0 comments · Fixed by #198

Comments

@ghost
Copy link

ghost commented Nov 7, 2019

JOSESwift/Tests/JWSRSATests.swift

Line 85 in b2e314a

XCTAssertEqual(compactSerializedJWS, compactSerializedJWS)

We have a pretty serious test bug in the line above where we are not properly checking against the correct expected value. Fix this function so that it gets passed the expected value as parameter.
@ghost ghost self-assigned this Nov 7, 2019
@ghost ghost mentioned this issue Nov 7, 2019
Merged
@ghost ghost mentioned this issue Feb 5, 2020
Merged
@ghost ghost closed this as completed in #198 Feb 14, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dry up signing roundtrip tests airsidemobile/JOSESwift
0 participants