Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Throw invalid delta error if change is out of range and added V2 for worker and worker client #4721

Merged
merged 2 commits into from
May 30, 2022

Conversation

andrewnester
Copy link
Contributor

Issue #, if available:

Description of changes:

Brought from c9 branch

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@andrewnester andrewnester requested a review from nightwing May 29, 2022 14:38
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #4721 (f116a8a) into master (bf2c7e2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4721      +/-   ##
==========================================
- Coverage   71.19%   71.18%   -0.01%     
==========================================
  Files         553      553              
  Lines       55598    55602       +4     
  Branches    10392    10393       +1     
==========================================
- Hits        39584    39582       -2     
- Misses      16014    16020       +6     
Flag Coverage Δ
unittests 71.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/worker/mirror.js 51.35% <0.00%> (-9.26%) ⬇️
lib/ace/range.js 84.82% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2c7e2...f116a8a. Read the comment docs.

@andrewnester andrewnester merged commit f269889 into ajaxorg:master May 30, 2022
@andrewnester andrewnester deleted the worker-v2 branch May 30, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants