Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass additional arguments for command.exec #4723

Merged
merged 1 commit into from
May 30, 2022

Conversation

andrewnester
Copy link
Contributor

Issue #, if available:

Description of changes:

Brought back from c9 branch

We pass 2 more new arguments:

event: Event, 
undefinedArguments: boolean

We have the flag undefinedArguments to know whether or not the arguments sent to the exec were initally undefined.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@andrewnester andrewnester requested a review from nightwing May 29, 2022 15:01
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #4723 (7db524d) into master (bf2c7e2) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4723      +/-   ##
==========================================
+ Coverage   71.19%   71.24%   +0.05%     
==========================================
  Files         553      553              
  Lines       55598    55600       +2     
  Branches    10392    10392              
==========================================
+ Hits        39584    39614      +30     
+ Misses      16014    15986      -28     
Flag Coverage Δ
unittests 71.24% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/commands/command_manager.js 82.35% <100.00%> (+0.53%) ⬆️
lib/ace/editor.js 81.61% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2c7e2...7db524d. Read the comment docs.

@andrewnester andrewnester merged commit 3b36762 into ajaxorg:master May 30, 2022
@andrewnester andrewnester deleted the command-manager branch May 30, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants